Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically

From: shihao zhong <zhong950419(at)gmail(dot)com>
To: Bohyun Lee <bohyun(dot)lee(at)databricks(dot)com>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, harrisontbooth(at)gmail(dot)com, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically
Date: 2026-10-22 03:46:05
Message-ID: CAGRkXqQ59JE=Rg21HjEOAuswaoYs89bSTM3QyoA2k2fT-t6Q+A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Bohyun,

Thanks for v9. My points on v6 are all handled. Two new ones.

1. ICU rules are not copied. If the old template0 has daticurules,
the new one has none and the upgrade still succeeds. A small fix is
attached.

2. If a real run fails in the checks, the new cluster stays, and the
same command then fails with "new cluster data directory is not
empty". Nothing has been copied yet at that point, so could it be
removed like in --check mode?

Thanks,
Shihao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-10-22 03:49:45 Re: [PATCH] pageinspect: validate line pointers before using them
Previous Message shihao zhong 2026-10-22 03:39:15 Re: [PG19] Indexes from 18 miss rows after pg_upgrade