| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-11-01 00:16:31 |
| Message-ID: | CAGRkXqS2tqU+ziabsALr4oTiK25C5=YTRGb0-C6=dYpKmAo0TA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit,
Sorry, I was not clear. The code is fine, I only meant the comment.
update_exists also passes NULL, but a search did happen before it.
So "NULL if no search was done" is not quite right.
Fixing get_tuple_desc() later is fine, let's do it separately.
0002 looks good. Maybe add a hint to the new error in
lock_conflictlog_relation(), like the two in subscriptioncmds.c.
Thanks,
Shihao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-11-01 00:21:35 | Re: [PG19] pg_upgrade --check passes, then the upgrade fails |
| Previous Message | Daniel Gustafsson | 2026-10-31 21:25:25 | Re: [PATCH] doc: Clarify pg_checksums --filenode mode restriction |