| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-10-31 11:05:40 |
| Message-ID: | CAA4eK1J7V9Kx7XJz9L8wD6MHoXdR72DRYUfFNoX5o417p59-hA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 31, 2026 at 10:17 AM shihao zhong <zhong950419(at)gmail(dot)com> wrote:
>
> Thanks for the fix! All six LOG callers pass the entry the search used.
>
> Two things:
>
> 1. The new comment says relmapentry is NULL when no search was done.
> But update_exists also passes NULL, and it did search.
>
AFAICS, to report update_exists, we call CheckAndReportConflict()
which always passes NULL in ReportApplyConflict(). Can you point us to
the code you are referring to?
> 2. Get_tuple_desc() still calls GetRelationIdentityOrPK(), so with
> conflict_log_destination = 'all' the log and the table can disagree.
>
This is a pre-existing wart which we can fix separately after this
patch as it would be easier to do so. I intentionally left it because
as noted in comments this is a pre-existing issue though a minor one
but if you or others feels we should fix it along with this patch then
we can do so, but I prefer to do it separately.
BTW, do you have any opinion on 0002 related to the two_phase option?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-10-31 11:07:33 | Re: [PATCH] pg_upgrade: handle failed nonblocking connects on Windows |
| Previous Message | Heikki Linnakangas | 2026-10-31 11:01:07 | Re: PL/pgSQL: "missing X at end of SQL expression" is never reported at end of input |