| From: | shihao zhong <zhong950419(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Collect ALTER PUBLICATION commands for event triggers |
| Date: | 2026-09-05 02:52:16 |
| Message-ID: | CAGRkXqQ1WDOE17dESEyUpyrVeDenjGqgnXRjJfste_45LjYxVA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Sorry for the delay. V2 looks good to me.
Hi,
I applied v2 on master with asserts and measured the output.
Please commit 0003 separately and soon. It is an unrelated five-line
fix for a v19 feature, and v19 has branched.
Do we need the following line in 003?
pubform = GETSTRUCT(tup) line;
heap_modify_tuple() does not change the OID.
0001/0002 collect when the catalog changed, but ddl_command_end means
the command ran. Measured, all three applied:
ADD TABLE t2 membership row only
SET TABLE t1,t2,t3 (same set) zero rows
DROP TABLE t1 publication row
SET (publish='insert') twice publication row both times
SET ALL TABLES (already all tables) zero rows
But one command now has two rules. And 0002's claim that it fixes "no
entry" for SET ALL TABLES is untrue for the no-op case
I think weneed to fix the commit message.
Thanks,
Shihao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shihao zhong | 2026-09-05 02:56:09 | Re: Collect ALTER PUBLICATION commands for event triggers |
| Previous Message | shihao zhong | 2026-09-05 02:16:38 | [PATCH] add missed tests for gist index |