| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Collect ALTER PUBLICATION commands for event triggers |
| Date: | 2026-08-06 06:30:27 |
| Message-ID: | B0458B0D-0D4E-43C8-A3C0-C10D09B632B6@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Jul 24, 2026, at 22:12, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
>> On Jul 24, 2026, at 21:54, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>> On Fri, Jul 24, 2026 at 5:38 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>> Both v1-0001 and v1-0002 look good to me.
>>
>> Thanks for the review!
>>
>>
>>> While reviewing 0002, I noticed another suspicion. AlterPublicationAllFlags() directly updates the pg_publication tuple but doesn’t call InvokeObjectPostAlterHook(). This seems inconsistent with AlterPublicationOptions() and AlterPublicationOwner_internal(), which invoke that hook after altering the publication.
>>>
>>> As this is a separate issue from this patch, should I start a new thread? This seems an oversight of 493f8c6439c.
>>
>> Good catch! Although it's a separate issue, I think it's fine to
>> discuss it here since it's a bit related and a small change.
>>
>> I put together a patch to invoke the post-alter hook for
>> ALTER PUBLICATION SET ALL. It's attached as patch 0003
>> in my reply to Ian upthread.
>>
>
> Yeah, that’s better. Thanks for adding 0003. I will review it next Monday.
>
Sorry for the delay. V2 looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-08-06 07:03:38 | Re: Add a hook for handling logical decoding messages on subscribers. |
| Previous Message | Peter Geoghegan | 2026-08-06 06:03:28 | Re: Whole row var issue |