From: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: CREATE/ALTER ROLE PASSWORD ('value' USING 'method') |
Date: | 2017-03-08 05:32:51 |
Message-ID: | CAGPqQf0FHZGx5ipBob1rdKzpV=syRAX2Px1tg=m440Eyu_We-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 8, 2017 at 9:59 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> > here is a separate thread dedicated to the following extension for
> > CREATE/ALTER ROLE: PASSWORD ('value' USING 'method').
>
> The parentheses seem weird ... do we really need those?
>
+1
I had quick glance to patch and it looks great.
One quick comments:
+ | PASSWORD '(' Sconst USING Sconst ')'
+ {
+ $$ = makeDefElem("methodPassword",
+ (Node *)list_make2(makeString($3),
+ makeString($5)),
+ @1);
+ }
methodPassword looks bit weird, can we change it to passwordMethod
or pwdEncryptMethod ?
> regards, tom lane
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
--
Rushabh Lathia
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2017-03-08 05:33:52 | Re: dropping partitioned tables without CASCADE |
Previous Message | Tsunakawa, Takayuki | 2017-03-08 05:17:41 | Re: some dblink refactoring |