| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CREATE/ALTER ROLE PASSWORD ('value' USING 'method') |
| Date: | 2017-03-08 06:50:08 |
| Message-ID: | CAB7nPqQeZnAY_Kw4rWwu9PrMKHfaS=5QG9F3HODOmNwS3oC5JQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 8, 2017 at 2:32 PM, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> wrote:
> One quick comments:
>
> + | PASSWORD '(' Sconst USING Sconst ')'
> + {
> + $$ = makeDefElem("methodPassword",
> + (Node *)list_make2(makeString($3),
> + makeString($5)),
> + @1);
> + }
>
> methodPassword looks bit weird, can we change it to passwordMethod
> or pwdEncryptMethod ?
Using "Password" in suffix looks still better to me though for
consistency with the other ones.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2017-03-08 06:52:26 | [bug fix] dblink leaks unnamed connections |
| Previous Message | Dilip Kumar | 2017-03-08 06:49:24 | Re: Parallel bitmap heap scan |