| From: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Flushing large data immediately in pqcomm |
| Date: | 2024-03-28 19:44:12 |
| Message-ID: | CAGPVpCSJN5sdSB6bjGCuP5v_6=zPhTeZef_VhsRStiyHci+rLg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 27, 2024 at 14:39 David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Fri, 22 Mar 2024 at 12:46, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
> > I did all of the above changes and it seems like those resolved the
> regression issue.
>
> Thanks for adjusting the patch. The numbers do look better, but on
> looking at your test.sh script from [1], I see:
>
> meson setup --buildtype debug -Dcassert=true
> --prefix="$DESTDIR/usr/local/pgsql" $DESTDIR && \
>
> can you confirm if the test was done in debug with casserts on? If
> so, it would be much better to have asserts off and have
> -Dbuildtype=release.
Yes, previous numbers were with --buildtype debug -Dcassert=true. I can
share new numbers with release build and asserts off soon.
Thanks,
Melih
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melih Mutlu | 2024-03-28 19:47:24 | Re: Flushing large data immediately in pqcomm |
| Previous Message | Tom Lane | 2024-03-28 19:36:14 | Re: Properly pathify the union planner |