| From: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, David Rowley <dgrowleyml(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Flushing large data immediately in pqcomm |
| Date: | 2024-03-28 19:47:24 |
| Message-ID: | CAGPVpCRbuc8GAdrD2HT4nXh3kvQw_1aU3FfvUU-iT4EU6ZgdtQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 27, 2024 at 18:54 Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Mar 27, 2024 at 7:39 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > Robert, I understand you'd like a bit more from this patch. I'm
> > wondering if you planning on blocking another committer from going
> > ahead with this? Or if you have a reason why the current state of the
> > patch is not a meaningful enough improvement that would justify
> > possibly not getting any improvements in this area for PG17?
>
> So, I think that the first version of the patch, when it got a big
> chunk of data, would just flush whatever was already in the buffer and
> then send the rest without copying.
Correct.
The current version, as I
> understand it, only does that if the buffer is empty; otherwise, it
> copies data as much data as it can into the partially-filled buffer.
Yes, currently it should fill and flush the buffer first, if it’s not
already empty. Only then it sends the rest without copying.
Thanks,
Melih
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-03-28 19:53:39 | Re: Properly pathify the union planner |
| Previous Message | Melih Mutlu | 2024-03-28 19:44:12 | Re: Flushing large data immediately in pqcomm |