| From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
|---|---|
| To: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improper use about DatumGetInt32 |
| Date: | 2020-11-27 12:33:36 |
| Message-ID: | CAGEoWWSG2QrL2K-cXysisf7tYcYe1firVzfMbBU0y+JSiuy4_g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 25, 2020 at 8:13 PM Anastasia Lubennikova <
a(dot)lubennikova(at)postgrespro(dot)ru> wrote:
> On 02.11.2020 18:59, Peter Eisentraut wrote:
> > I have committed 0003.
> >
> > For 0001, normal_rand(), I think you should reject negative arguments
> > with an error.
>
> I've updated 0001. The change is trivial, see attached.
>
> >
> > For 0002, I think you should change the block number arguments to
> > int8, same as other contrib modules do.
> >
> Agree. It will need a bit more work, though. Probably a new version of
> pageinspect contrib, as the public API will change.
> Ashutosh, are you going to continue working on it?
>
Sorry I was away on Diwali vacation so couldn't address Peter's comments in
time. Thanks for taking this further. I will review Peter's patch.
--
Best Wishes,
Ashutosh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Seino Yuki | 2020-11-27 12:37:23 | Re: Feature improvement for pg_stat_statements |
| Previous Message | Ashutosh Bapat | 2020-11-27 12:05:00 | Re: A problem about partitionwise join |