| From: | Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improper use about DatumGetInt32 |
| Date: | 2020-11-25 14:43:03 |
| Message-ID: | 0a25634d-19b5-4d07-acfc-ccf6ce058fe3@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02.11.2020 18:59, Peter Eisentraut wrote:
> I have committed 0003.
>
> For 0001, normal_rand(), I think you should reject negative arguments
> with an error.
I've updated 0001. The change is trivial, see attached.
>
> For 0002, I think you should change the block number arguments to
> int8, same as other contrib modules do.
>
Agree. It will need a bit more work, though. Probably a new version of
pageinspect contrib, as the public API will change.
Ashutosh, are you going to continue working on it?
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Handle-negative-number-of-tuples_v1.patch | text/x-patch | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2020-11-25 15:00:16 | Re: Implementing Incremental View Maintenance |
| Previous Message | Bharath Rupireddy | 2020-11-25 14:38:57 | Re: Use standard SIGHUP and SIGTERM handlers in autoprewarm module |