Re: Printing LSN made easy

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Subject: Re: Printing LSN made easy
Date: 2020-11-30 13:19:03
Message-ID: CAGEoWWQtgDbnHvyVaLARqCB2qHwEbyc2C3Pv0pyXmf4amHzL2A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 29, 2020 at 10:40 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > On Fri, Nov 27, 2020 at 04:10:27PM +0530, Ashutosh Bapat wrote:
> >> Off list Craig Ringer suggested introducing a new format specifier
> >> similar to %m for LSN but I did not get time to take a look at the
> >> relevant code. AFAIU it's available only to elog/ereport, so may not
> >> be useful generally. But teaching printf variants about the new format
> >> would be the best solution. However, I didn't find any way to do that.
>
> > -1. %m maps to errno, that is much more generic. A set of macros
> > that maps to our internal format would be fine enough IMO.
>
> Agreed. snprintf.c is meant to implement a recognized standard
> (ok, %m is a GNU extension, but it's still pretty standard).
> I'm not on board with putting PG-only extensions in there.
>

Thanks for the clarification.

--
Best Wishes,
Ashutosh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-11-30 13:20:35 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Previous Message Ashutosh Bapat 2020-11-30 13:18:32 Re: Printing LSN made easy