| From: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Sergey Prokhorenko <sergeyprokhorenko(at)yahoo(dot)com(dot)au>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions |
| Date: | 2025-10-28 23:35:28 |
| Message-ID: | CAGECzQTEK58Ef8w5xA=8KGT6D2seHF0fN0XNdgRov7Lp4bitGQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 28 Oct 2025 at 17:41, Dagfinn Ilmari Mannsåker
<ilmari(at)ilmari(dot)org> wrote:
> Here's a patch for that.
Looks good to me. Maybe add a test where not every byte is the same though.
> I'm not 100% confident about the error code
> for invalid length, but that was the closest one I could find in
> errcodes.txt.
The errorcode you chose seems acceptable to me, but I think a slightly
more fitting option would be ERRCODE_INVALID_BINARY_REPRESENTATION.
Error codes in postgres are pretty arbitrary though, so either seems
fine to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Luis Felippe | 2025-10-28 23:43:48 | Re: [PATCH] Fix ICU strength not being honored in collation rules |
| Previous Message | Joe Conway | 2025-10-28 22:49:07 | Re: contrib/sepgsql regression tests have been broken for months |