Re: Make copyObject work in C++

From: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Make copyObject work in C++
Date: 2026-03-31 09:09:59
Message-ID: CAGECzQRauVYN19Y-DTiCTCkdNabh+ZqhdaLrUHR6CAU4wm2TFQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 31 Mar 2026 at 10:33, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> Hmm, note that C++ is also used for LLVM/JIT, and by requiring this
> additional feature set we are also imposing new requirements for those
> users. This has not been fully explored, and I hesitate to add such a
> new requirement at the last moment.

I understand the hesitation, but in practice we already impose those
requirements anyway for non-MSVC compilers because test_cplusplusext
doesn't compile without it. So any compiler that would cause problems
with the new featureset would have already complained about that
before.

> But how about this: We add the feature test that you propose and enable
> the extension based on that. See attached patch. This reduces to
> essentially a three-line patch, much simpler than all previous proposals.

If you're still worried, then this sounds like a fine middle-ground
for now. I think we should reconsider adding the automatic /std:c++20
flag for the PG20 dev cycle though.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yura Sokolov 2026-03-31 09:15:59 Re: BM_IO_ERROR flag is lost in TerminateBufferIO due to order of operations in UnlockBufHdrExt
Previous Message Chao Li 2026-03-31 09:09:19 Re: Eliminating SPI / SQL from some RI triggers - take 3