Re: Make copyObject work in C++

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Make copyObject work in C++
Date: 2026-04-01 05:54:07
Message-ID: 8f4a2a1e-6142-4481-bc21-76fd33419103@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 31.03.26 11:09, Jelte Fennema-Nio wrote:
> On Tue, 31 Mar 2026 at 10:33, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> Hmm, note that C++ is also used for LLVM/JIT, and by requiring this
>> additional feature set we are also imposing new requirements for those
>> users. This has not been fully explored, and I hesitate to add such a
>> new requirement at the last moment.
>
> I understand the hesitation, but in practice we already impose those
> requirements anyway for non-MSVC compilers because test_cplusplusext
> doesn't compile without it. So any compiler that would cause problems
> with the new featureset would have already complained about that
> before.
>
>> But how about this: We add the feature test that you propose and enable
>> the extension based on that. See attached patch. This reduces to
>> essentially a three-line patch, much simpler than all previous proposals.
>
> If you're still worried, then this sounds like a fine middle-ground
> for now. I think we should reconsider adding the automatic /std:c++20
> flag for the PG20 dev cycle though.

Ok, I have committed the shown patch.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-04-01 06:16:00 DOCS - DROP SUBSCRIPTION does not document parameter "IF EXISTS"
Previous Message Nisha Moond 2026-04-01 05:33:51 Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?