| From: | Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] psql: Fix REPACK index completion after a column list |
| Date: | 2026-11-10 03:38:27 |
| Message-ID: | CAG7L5+5wYkMpwxmjoJPMpjp4p3DO52AYvvSgCrt-VwY4PP7C=w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Chao,
Thank you for reviewing.
Since these two patches are closely related, I would suggest combining them
> into a single patch. I applied this patch first, but when I tried to apply
> the other one, I encountered a conflict. Combining them would make it
> easier for reviewers and committers to review and apply the changes.
>
I've combined both fixes in the attached v2 code
patch (0001), with the regression tests in a separate patch (0002).
The code combines the two v1 fixes.
I will withdraw Commitfest entry #7610 [1].
[1] https://commitfest.postgresql.org/patch/7610/
Thanks,
Sho
--
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
*Sho Ito (Sean)*
E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-psql-Add-regression-tests-for-REPACK-tab-completi.patch | application/octet-stream | 3.1 KB |
| v2-0001-psql-Fix-REPACK-tab-completion-around-USING-INDEX.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sho Ito | 2026-11-10 03:41:46 | Re: [PATCH] psql: Complete INDEX after REPACK USING |
| Previous Message | shihao zhong | 2026-11-10 03:34:36 | Re: [PATCH] Periodically refresh database frozen IDs during autovacuum |