Re: [PATCH] psql: Fix REPACK index completion after a column list

> On Nov 10, 2026, at 11:38, Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com> wrote:
>
> Hi Chao,
>
> Thank you for reviewing.
>
> Since these two patches are closely related, I would suggest combining them into a single patch. I applied this patch first, but when I tried to apply the other one, I encountered a conflict. Combining them would make it easier for reviewers and committers to review and apply the changes.
>
> I've combined both fixes in the attached v2 code
> patch (0001), with the regression tests in a separate patch (0002).
> The code combines the two v1 fixes.
>
> I will withdraw Commitfest entry #7610 [1].
>
> [1] https://commitfest.postgresql.org/patch/7610/
> Thanks,
> Sho
>
> --
> ＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
> Sho Ito (Sean)
>
> E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
> LinkedIn: https://www.linkedin.com/in/sho-ito-0628/
> GitHub: https://github.com/sean0628/
> ＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝＝
> <v2-0002-psql-Add-regression-tests-for-REPACK-tab-completi.patch><v2-0001-psql-Fix-REPACK-tab-completion-around-USING-INDEX.patch>

Thanks for updating the patch. When testing v2, I found a problem:
```
evantest=# repack t (a)USING INDEX ;
ERROR: ANALYZE option must be specified when a column list is provided
```

After I typed in “(a)”, a tab typing auto filled in “USING INDEX”, but you can see the error. A column list is only allowed with ANALYZE specified. So,
```
Matches("REPACK", MatchAny, "(*)")
```

is questionable. It matches to above example.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/