Re: [DEPARSE] Parameters in SQL-standard function bodies do not read back

From: Sho Ito <i(dot)sho(dot)0628(at)gmail(dot)com>
To: assam258(at)gmail(dot)com
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [DEPARSE] Parameters in SQL-standard function bodies do not read back
Date: 2026-11-08 00:03:07
Message-ID: CAG7L5+4wCe9fJ_+6fhEx72a7aXd6Hm7-cv2-jWajsiNbcX_1PQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 30, 2026 at 3:41 AM Henson Choi <assam258(at)gmail(dot)com> wrote:

> A function created again by dump and
> restore, or from pg_get_functiondef() output, then silently gives a
> different result, or is not created at all. The two attached patches
> add tests and fix it.
>

Hi Henson,

I reviewed both v1 patches on master with assertions enabled.
`make check` passes. Additional `pg_get_functiondef()` round trips and
`pg_dump`/restore
checks returned the same results before and after recreation for nested
scopes, renames, composite parameters, and unnamed parameters.
I found no issues with the fix.

Thanks,
Sho

--
=======================================
*Sho Ito (Sean)*

E-mail: i(dot)sho(dot)0628(at)gmail(dot)com
LinkedIn: *https://www.linkedin.com/in/sho-ito-0628/
<https://www.linkedin.com/in/sho-ito-0628/>*
GitHub: https://github.com/sean0628/
=======================================

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-11-08 00:08:34 Re: improving handling of FPIs during recovery prefetching
Previous Message Tomas Vondra 2026-11-07 23:01:57 Re: Two bugs in reconsider_full_join_clause(), handling coalesce() = const clauses