| From: | Zhijie Hou <houzhijie22(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>, kedar anavardekar <kedar(dot)anavardekar(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Fix WITHOUT OVERLAPS multirange with location replication |
| Date: | 2026-10-13 12:16:33 |
| Message-ID: | CAFvd2n_aE4UBiLcumLOUx8HZhOvR-R-W1qkmAwhYemoidg5jNA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Oct 13, 2026 at 7:21 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Oct 13, 2026 at 5:37 AM Paul A Jungwirth
> <pj(at)illuminatedcomputing(dot)com> wrote:
> >
> > This v4 looks good to me. Thank you for helping with this! Maybe one
> > minor change:
> >
> > src/test/subscription/t/035_conflicts.pl
> > +# Publisher table holding the row that will be updated.
> > +$node_B->safe_psql(
> > + 'postgres', "
> > + CREATE TABLE tab_mr (id int4multirange, valid_at daterange, v int);
> > + ALTER TABLE tab_mr REPLICA IDENTITY FULL;
> > + INSERT INTO tab_mr VALUES ('{[1,5)}', '[2000-01-01,2010-01-01)', 1);
> > + ALTER PUBLICATION tap_pub_B ADD TABLE tab_mr;
> > +");
> >
> > If we say PRIMARY KEY (id, valid_at WITHOUT OVERLAPS) then we don't
> > need REPLICA IDENTITY FULL.
> >
>
> Yeah, but keeping RI FULL also doesn't harm; rather it tests something
> extra which is that it can extract required values from the full
> tuple. So, I am okay either way. I have modified the comments at
> multiple places in the patch as I find there is a lot of redundancy in
> the comments. See attached top-up patch. BTW, we need a separate patch
> for v18 as well.
Thanks for the diff. I have merged and prepared the patches for
back branches as well.
Best Regards,
Zhijie Hou
| Attachment | Content-Type | Size |
|---|---|---|
| v5_PG19-0001-Fix-logical-replication-with-multirange-WITH.patch | application/octet-stream | 13.3 KB |
| v5-0001-Fix-logical-replication-with-multirange-WITHOUT-O.patch | application/octet-stream | 13.3 KB |
| v5_PG18-0001-Fix-logical-replication-with-multirange-WITH.patch | application/octet-stream | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Boris Mironov | 2026-10-13 12:17:36 | Re: Idea to enhance pgbench by more modes to generate data (multi-TXNs, UNNEST, COPY BINARY) |
| Previous Message | Koshi Shibagaki (Fujitsu) | 2026-10-13 11:57:44 | Re: CREATE TABLE .. LIKE copies comments to an unrelated table |