| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
| Cc: | Zhijie Hou <houzhijie22(at)gmail(dot)com>, kedar anavardekar <kedar(dot)anavardekar(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Fix WITHOUT OVERLAPS multirange with location replication |
| Date: | 2026-10-13 11:21:32 |
| Message-ID: | CAA4eK1LPCE71QjLB9vO1f3mv+YsKtJ6uqk2MZc4heVxcWAugdQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 13, 2026 at 5:37 AM Paul A Jungwirth
<pj(at)illuminatedcomputing(dot)com> wrote:
>
> This v4 looks good to me. Thank you for helping with this! Maybe one
> minor change:
>
> src/test/subscription/t/035_conflicts.pl
> +# Publisher table holding the row that will be updated.
> +$node_B->safe_psql(
> + 'postgres', "
> + CREATE TABLE tab_mr (id int4multirange, valid_at daterange, v int);
> + ALTER TABLE tab_mr REPLICA IDENTITY FULL;
> + INSERT INTO tab_mr VALUES ('{[1,5)}', '[2000-01-01,2010-01-01)', 1);
> + ALTER PUBLICATION tap_pub_B ADD TABLE tab_mr;
> +");
>
> If we say PRIMARY KEY (id, valid_at WITHOUT OVERLAPS) then we don't
> need REPLICA IDENTITY FULL.
>
Yeah, but keeping RI FULL also doesn't harm; rather it tests something
extra which is that it can extract required values from the full
tuple. So, I am okay either way. I have modified the comments at
multiple places in the patch as I find there is a lot of redundancy in
the comments. See attached top-up patch. BTW, we need a separate patch
for v18 as well.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-amit-1.patch | application/octet-stream | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-10-13 11:27:36 | RE: Test publication.sql racing with subscription.sql might fail due to cache lookup error |
| Previous Message | Jakub Wartak | 2026-10-13 11:14:11 | Re: [(known) BUG] DELETE/UPDATE more than one row in partitioned foreign table |