Re: [PATCH} Move instrumentation structs

From: Mario González Troncoso <gonzalemario(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH} Move instrumentation structs
Date: 2026-01-06 15:53:40
Message-ID: CAFsReFXTrf16wyKQAAKmzisy9th8UqH5cgtdTn3m8PAe1-3G+A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 5 Jan 2026 at 11:39, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-Jan-05, Mario González Troncoso wrote:
>
> > Hey there. I'm updating the patch.
>
> Thanks. Coincidentally, while I rode the train a few hundred kilometers
> from your place yesterday, I was editing the comments in 0001 as I had
> mentioned. The only non-comment change, I think, is that you had left
> #define NUM_TUPLESORTMETHODS in two places, which was quite odd. I
> removed the one in tuplesort.h and the comment that accompanied it.
> Here's what I ended up with. What do you think?
>

Awesome. Yesterday I heard the train and I thought, it might be Alvaro
that's passing by.

lgtm to the changes, thanks mate!

> I also happened to notice an old typo "its" which should be "it's" in
> tuplesort.c while reading your patch.
>
> --
> Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
> Y una voz del caos me habló y me dijo
> "Sonríe y sé feliz, podría ser peor".
> Y sonreí. Y fui feliz.
> Y fue peor.

--
Mario Gonzalez
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2026-01-06 15:58:18 Re: Implement waiting for wal lsn replay: reloaded
Previous Message Xuneng Zhou 2026-01-06 15:53:11 Re: Implement waiting for wal lsn replay: reloaded