| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Mario González Troncoso <gonzalemario(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH} Move instrumentation structs |
| Date: | 2026-01-05 14:38:59 |
| Message-ID: | 202601051428.gpkpkkgwenxe@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-Jan-05, Mario González Troncoso wrote:
> Hey there. I'm updating the patch.
Thanks. Coincidentally, while I rode the train a few hundred kilometers
from your place yesterday, I was editing the comments in 0001 as I had
mentioned. The only non-comment change, I think, is that you had left
#define NUM_TUPLESORTMETHODS in two places, which was quite odd. I
removed the one in tuplesort.h and the comment that accompanied it.
Here's what I ended up with. What do you think?
I also happened to notice an old typo "its" which should be "it's" in
tuplesort.c while reading your patch.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Y una voz del caos me habló y me dijo
"Sonríe y sé feliz, podría ser peor".
Y sonreí. Y fui feliz.
Y fue peor.
| Attachment | Content-Type | Size |
|---|---|---|
| v3a-0001-edit-comments-and-stuff.txt | text/plain | 11.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2026-01-05 14:51:58 | Re: [PATCH] Precompute string lengths in PerformRadiusTransaction |
| Previous Message | zengman | 2026-01-05 14:36:18 | [PATCH] Precompute string lengths in PerformRadiusTransaction |