Re: Proposal: Adding compression of temporary files

From: Filip Janus <fjanus(at)redhat(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Proposal: Adding compression of temporary files
Date: 2025-08-18 16:51:57
Message-ID: CAFjYY+LH=MbMpGiYfMtPsANDBAqiDC66hD3tBs_JeVcBYVcmHA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I rebased the proposal and fixed the problem causing those problems.

-Filip-

út 17. 6. 2025 v 16:49 odesílatel Andres Freund <andres(at)anarazel(dot)de> napsal:

> Hi,
>
> On 2025-04-25 23:54:00 +0200, Filip Janus wrote:
> > The latest rebase.
>
> This often seems to fail during tests:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5382
>
> E.g.
>
> https://api.cirrus-ci.com/v1/artifact/task/4667337632120832/testrun/build-32/testrun/recovery/027_stream_regress/log/regress_log_027_stream_regress
>
> === dumping
> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/regression.diffs
> ===
> diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/join_hash_pglz.out
> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/join_hash_pglz.out
> --- /tmp/cirrus-ci-build/src/test/regress/expected/join_hash_pglz.out
> 2025-05-26 05:04:40.686524215 +0000
> +++
> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/join_hash_pglz.out
> 2025-05-26 05:15:00.534907680 +0000
> @@ -594,11 +594,8 @@
> select count(*) from join_foo
> left join (select b1.id, b1.t from join_bar b1 join join_bar b2 using
> (id)) ss
> on join_foo.id < ss.id + 1 and join_foo.id > ss.id - 1;
> - count
> --------
> - 3
> -(1 row)
> -
> +ERROR: could not read from temporary file: read only 8180 of 1572860
> bytes
> +CONTEXT: parallel worker
> select final > 1 as multibatch
> from hash_join_batches(
> $$
> @@ -606,11 +603,7 @@
> left join (select b1.id, b1.t from join_bar b1 join join_bar b2
> using (id)) ss
> on join_foo.id < ss.id + 1 and join_foo.id > ss.id - 1;
> $$);
> - multibatch
> -------------
> - t
> -(1 row)
> -
> +ERROR: current transaction is aborted, commands ignored until end of
> transaction block
> rollback to settings;
> -- single-batch with rescan, parallel-oblivious
> savepoint settings;
>
>
> Greetings,
>
> Andres
>
>
>

Attachment Content-Type Size
0002-Add-regression-tests-for-temporary-file-compression.patch application/octet-stream 126.8 KB
0001-Add-transparent-compression-for-temporary-files.patch application/octet-stream 18.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-08-18 16:52:27 Re: VM corruption on standby
Previous Message Tom Lane 2025-08-18 16:38:35 Re: When deleting the plpgsql function, release the CachedPlan of the function