Re: Proposal: Adding compression of temporary files

From: Filip Janus <fjanus(at)redhat(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Proposal: Adding compression of temporary files
Date: 2025-08-19 15:48:31
Message-ID: CAFjYY+Jfsy1r4ZP4+RyHZeWE7JyT4LSdVFvA9ck04LFkKd1ebw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fix overlooked compiler warnings

-Filip-

po 18. 8. 2025 v 18:51 odesílatel Filip Janus <fjanus(at)redhat(dot)com> napsal:

> I rebased the proposal and fixed the problem causing those problems.
>
> -Filip-
>
>
> út 17. 6. 2025 v 16:49 odesílatel Andres Freund <andres(at)anarazel(dot)de>
> napsal:
>
>> Hi,
>>
>> On 2025-04-25 23:54:00 +0200, Filip Janus wrote:
>> > The latest rebase.
>>
>> This often seems to fail during tests:
>> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5382
>>
>> E.g.
>>
>> https://api.cirrus-ci.com/v1/artifact/task/4667337632120832/testrun/build-32/testrun/recovery/027_stream_regress/log/regress_log_027_stream_regress
>>
>> === dumping
>> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/regression.diffs
>> ===
>> diff -U3
>> /tmp/cirrus-ci-build/src/test/regress/expected/join_hash_pglz.out
>> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/join_hash_pglz.out
>> --- /tmp/cirrus-ci-build/src/test/regress/expected/join_hash_pglz.out
>> 2025-05-26 05:04:40.686524215 +0000
>> +++
>> /tmp/cirrus-ci-build/build-32/testrun/recovery/027_stream_regress/data/results/join_hash_pglz.out
>> 2025-05-26 05:15:00.534907680 +0000
>> @@ -594,11 +594,8 @@
>> select count(*) from join_foo
>> left join (select b1.id, b1.t from join_bar b1 join join_bar b2 using
>> (id)) ss
>> on join_foo.id < ss.id + 1 and join_foo.id > ss.id - 1;
>> - count
>> --------
>> - 3
>> -(1 row)
>> -
>> +ERROR: could not read from temporary file: read only 8180 of 1572860
>> bytes
>> +CONTEXT: parallel worker
>> select final > 1 as multibatch
>> from hash_join_batches(
>> $$
>> @@ -606,11 +603,7 @@
>> left join (select b1.id, b1.t from join_bar b1 join join_bar b2
>> using (id)) ss
>> on join_foo.id < ss.id + 1 and join_foo.id > ss.id - 1;
>> $$);
>> - multibatch
>> -------------
>> - t
>> -(1 row)
>> -
>> +ERROR: current transaction is aborted, commands ignored until end of
>> transaction block
>> rollback to settings;
>> -- single-batch with rescan, parallel-oblivious
>> savepoint settings;
>>
>>
>> Greetings,
>>
>> Andres
>>
>>
>>

Attachment Content-Type Size
0001-Add-transparent-compression-for-temporary-files.patch application/octet-stream 19.0 KB
0002-Add-regression-tests-for-temporary-file-compression.patch application/octet-stream 126.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2025-08-19 15:55:41 Re: Performance issue on temporary relations
Previous Message 章晨曦 2025-08-19 15:45:03 Re: Performance issue on temporary relations