From: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
---|---|
To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Obsolete comment in postgres_fdw.c |
Date: | 2016-03-14 07:42:26 |
Message-ID: | CAFjFpRfiescMihU4aYYz3Wh_=8C+WWZvw2kXGtv23g3xnO9DPA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 14, 2016 at 9:05 AM, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
wrote:
> Hi,
>
> Here is the comments for foreign_join_ok in postgres_fdw.c:
>
> /*
> * Assess whether the join between inner and outer relations can be
> pushed down
> * to the foreign server. As a side effect, save information we obtain
> in this
> * function to PgFdwRelationInfo passed in.
> *
> * Joins that satisfy conditions below are safe to push down.
> *
> * 1) Join type is INNER or OUTER (one of LEFT/RIGHT/FULL)
> * 2) Both outer and inner portions are safe to push-down
> * 3) All foreign tables in the join belong to the same foreign server
> and use
> * the same user mapping.
> * 4) All join conditions are safe to push down
> * 5) No relation has local filter (this can be relaxed for INNER JOIN,
> if we
> * can move unpushable clauses upwards in the join tree).
> */
>
>
The condition 3 is now checked by the core, so I'd like to remove that
> condition from the above comments.
>
It was left there intentionally to document all the conditions in one place
(some from the core and some from the FDW itself), for a ready reference.
In case tomorrow core thinks that matching user mapping is not required,
postgres_fdw would still require it to be incorporated.
>
> In addition, I'd like to update some related comments in
> src/include/nodes/relation.h and src/backend/optimizer/path/joinpath.c.
>
Those look fine. Sorry for missing those in the commit and thanks for
providing a patch for the same.
--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company
From | Date | Subject | |
---|---|---|---|
Next Message | Torsten Zühlsdorff | 2016-03-14 07:47:37 | Re: [HACKERS] How can we expand PostgreSQL ecosystem? |
Previous Message | Craig Ringer | 2016-03-14 07:08:01 | Re: Logical decoding slots can go backwards when used from SQL, docs are wrong |