Re: Thinko/typo in ExecSimpleRelationInsert

From: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thinko/typo in ExecSimpleRelationInsert
Date: 2018-06-27 06:00:13
Message-ID: CAFjFpRecoab=qpjOeSZ1Qf5tH3GvY+JrExqay-_hB+XYWQGSFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 27, 2018 at 11:24 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> I don't understand what do you mean by consistent. Do you mean to say
>> that current usage " Store the slot into tuple ... " is correct?
>>
>
> Oh no, I was talking about replacing it with below comment which is
> used at other places in the code.
> /*
> * get the heap tuple out of the tuple table slot, making sure we have a
> * writable copy
> */

Probably yes. But I would just correct the usage and grammar.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-06-27 06:03:54 Re: partitioning - changing a slot's descriptor is expensive
Previous Message Rajkumar Raghuwanshi 2018-06-27 05:59:45 Re: unexpected relkind: 73 ERROR with partition table index