Re: Thinko/typo in ExecSimpleRelationInsert

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Thinko/typo in ExecSimpleRelationInsert
Date: 2018-06-27 13:15:32
Message-ID: CAA4eK1JgRb9+gk0s7E54KwGEtv0j=DRKzPUjDSX+SKekEiLT7g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 27, 2018 at 11:30 AM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> On Wed, Jun 27, 2018 at 11:24 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>>
>>> I don't understand what do you mean by consistent. Do you mean to say
>>> that current usage " Store the slot into tuple ... " is correct?
>>>
>>
>> Oh no, I was talking about replacing it with below comment which is
>> used at other places in the code.
>> /*
>> * get the heap tuple out of the tuple table slot, making sure we have a
>> * writable copy
>> */
>
> Probably yes. But I would just correct the usage and grammar.
>

Okay, pushed!

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2018-06-27 13:16:07 Re: Does logical replication supports cross platform servers?
Previous Message Amit Kapila 2018-06-27 13:06:51 Re: Few cosmetic suggestions for commit 16828d5c (Fast Alter Table Add Column...)