Re: dropping table in testcase alter_table.sql

On Thu, Jul 7, 2011 at 9:41 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Thu, Jul 7, 2011 at 3:05 AM, Ashutosh Bapat
> <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> > I noticed that the test alter_table.sql is creating two tables tab1 and
> tab2
> > and it's not dropping it. Any test which follows this test and tries to
> > create tables with names tab1 and tab2 will fail (unless it drops those
> > tables first, but that may not work, since tab2.y depends upon tab1 in
> > alter_table.sql).
> >
> > PFA patch which drops these two tables from alter_table.sql and
> > corresponding OUT change. The regression run clean with this patch.
>
> The regression tests leave lots of objects lying around in the
> regression database... why drop these two, as opposed to any of the
> others?
>

I think, tab1 and tab2 are too common names, for anyone to pick up for the
tables. Also, the test alter_table.sql is dropping many other tables (even
those which have undergone renaming), then why not these two?

>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--
Best Wishes,
Ashutosh Bapat
EntepriseDB Corporation
The Enterprise Postgres Company