Re: proposal (9.5) : psql unicode border line styles

Hi

I removed dynamic allocation and reduced patch size.

What I tested a old unicode style is same as new unicode style. There
nothing was changed .. some fields are specified in refresh_utf8format
function

Regards

Pavel

2014-09-08 4:44 GMT+02:00 Stephen Frost <sfrost(at)snowman(dot)net>:

> Pavel,
>
> * Pavel Stehule (pavel(dot)stehule(at)gmail(dot)com) wrote:
> > 2014-07-23 8:38 GMT+02:00 Tomas Vondra <tv(at)fuzzy(dot)cz>:
> > > OK, thanks. The new version seems OK to me.
> >
> > Thank you
>
> I've started looking over the patch and went back through the previous
> thread about it. For my part, I'm in favor of adding this capability,
> but I'm not terribly happy about how it was done. In particular,
> get_line_style() seems pretty badly hacked around, and I don't really
> like having the prepare_unicode_format call underneath it allocating
> memory and then passing back up the need to free that memory via a new
> field in the structure. Also, on a quick glance, are you sure that the
> new 'unicode' output matches the same as the old 'unicode' did (with
> pg_utf8format)?
>
> I would think we'd simply set up a structure which is updated when the
> linestyle is changed, which is surely going to be much less frequently
> than the request for which linestyle to use happens, and handle all of
> the line styles in more-or-less the same way rather than doing something
> completely different for unicode than for the others.
>
> Thanks,
>
> Stephen
>