Re: Proposal: SET ROLE hook

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal: SET ROLE hook
Date: 2016-01-06 10:39:12
Message-ID: CAFj8pRCvXpWYR8VWEjcBsMo0dcV7cTboXHFA6DW9RYVNhZs6jg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

I did a review of this patch.

1. the proposal is clean and there are not any objection against it. I
checked a implementation, and it does exactly same what was proposed.

2. This hook has impact only on SET role to XXX statement, what isn't used
in our critical path, so there are not any performance impact

3. I was able to apply patch cleanly without any problems, warnings.

4. All regress tests was passed

5. there are not tests and documentation, but it is usual for any hook

I have not any objection

I'll mark this patch as ready for commiter

Regards

Pavel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2016-01-06 11:16:20 Re: Optimizer questions
Previous Message Shulgin, Oleksandr 2016-01-06 10:38:04 Re: Inconsistent error handling in START_REPLICATION command