Re: proposal: minscale, rtrim, btrim functions for numeric

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Marko Tiikkaja <marko(at)joh(dot)to>
Subject: Re: proposal: minscale, rtrim, btrim functions for numeric
Date: 2019-11-10 06:35:40
Message-ID: CAFj8pRChytNyGuWzde1q7gr6gQuCHOUn5Gdak-zKyV9oCRo14w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

so 9. 11. 2019 v 21:34 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:

> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > four years ago Marko Tiikkaja send a patch for numeric_trim functions.
> This
> > functions removed ending zeroes from numeric value. This is useful
> feature,
> > but there was not any progress on this patch. I think so this feature can
> > be interesting, so I would to revitalize this patch.
>
> > Original discussion
> >
> https://www.postgresql-archive.org/Add-numeric-trim-numeric-td5874444.html
>
> A more useful link is
> https://www.postgresql.org/message-id/flat/564D3ADB.7000808%40joh.to
> and the earlier discussion is at
> https://www.postgresql.org/message-id/flat/5643125E.1030605%40joh.to
>
> Re-reading that thread, I don't really think there's much support for
> anything beyond the minscale() function. The rest are just inviting
> confusion with string-related functions. And I really don't like
> establishing a precedent that btrim() and rtrim() are the same.
>

I have to agree, so using trim, rtrim names is not best. On second hand,
probably to most often usage of minscale function will be inside expression
round(x, minscale(x)), so this functionality can be in core. A question is
a name.

maybe to_minscale(numeric) ?

Regards

Pavel

> regards, tom lane
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2019-11-10 06:37:24 Re: First-draft back-branch release notes are up for review
Previous Message Tom Lane 2019-11-10 05:42:40 Re: Handy describe_pg_lock function