From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: bug: pg_dump use strange tag for trigger |
Date: | 2022-11-06 16:14:46 |
Message-ID: | CAFj8pRCdaqocci6AVuSoQB3aocbOx7E+E=V+xy=QjhELb__aaw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
ne 6. 11. 2022 v 15:52 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> > When I played with regression tests for pg_restore, I tested -T filtering
> > triggers too. I had problems with restoring triggers. I found that the
> name
> > for trigger uses the pattern "tablename triggername" (not just (and
> > correct) triggername).
>
> > I propose to generate tag just like trigger name
>
> Trigger names by themselves aren't even a little bit unique, so that
> doesn't seem like a great idea to me. There's backwards compatibility
> to worry about, too. Maybe we need a documentation adjustment, instead?
>
I understand, but the space is a little bit non intuitive. Maybe use dot
there and better documentation.
Regards
Pavel
>
> regards, tom lane
>
From | Date | Subject | |
---|---|---|---|
Next Message | Nikolay Shaplov | 2022-11-06 16:22:09 | Re: [PATCH] New [relation] option engine |
Previous Message | Tom Lane | 2022-11-06 16:14:29 | Re: Draft back-branch release notes are up |