Re: bug: pg_dump use strange tag for trigger

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: bug: pg_dump use strange tag for trigger
Date: 2022-11-06 14:52:14
Message-ID: 3011146.1667746334@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> When I played with regression tests for pg_restore, I tested -T filtering
> triggers too. I had problems with restoring triggers. I found that the name
> for trigger uses the pattern "tablename triggername" (not just (and
> correct) triggername).

> I propose to generate tag just like trigger name

Trigger names by themselves aren't even a little bit unique, so that
doesn't seem like a great idea to me. There's backwards compatibility
to worry about, too. Maybe we need a documentation adjustment, instead?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message gkokolatos 2022-11-06 14:53:12 Re: Add LZ4 compression in pg_dump
Previous Message Álvaro Herrera 2022-11-06 13:51:52 Re: Small TAP improvements