From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal - psql - use pager for \watch command |
Date: | 2021-03-23 05:30:49 |
Message-ID: | CAFj8pRCQ4dpCdPbcyOfNZamnXjya0SshvDVqPOc7HKLa_gYVcg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
út 23. 3. 2021 v 0:35 odesílatel Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
napsal:
> On Sun, Mar 21, 2021 at 11:43 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> wrote:
> > so 20. 3. 2021 v 23:45 odesílatel Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
> napsal:
> >> Thoughts? I put my changes into a separate patch for clarity, but
> >> they need some more tidying up.
> >
> > yes, your solution is much better.
>
> Hmm, there was a problem with it though: it blocked ^C while running
> the query, which is bad. I fixed that. I did some polishing of the
> code and some editing on the documentation and comments. I disabled
> the feature completely on Windows, because it seems unlikely that
> we'll be able to know if it even works, in this cycle.
>
> - output = PageOutput(158, pager ? &(pset.popt.topt) : NULL);
> + output = PageOutput(160, pager ? &(pset.popt.topt) : NULL);
>
> What is that change for?
>
This is correct - this is the number of printed rows - it is used for
decisions about using a pager for help. There are two new rows, and the
number is correctly +2
Pavel
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-03-23 05:31:30 | Re: Change default of checkpoint_completion_target |
Previous Message | Michael Paquier | 2021-03-23 05:24:28 | Re: Proposal: Save user's original authenticated identity for logging |