Re: WITHIN GROUP patch

2013/10/9 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>

> Hello
>
> I checked a conformance with ANSI SQL - and I didn't find any issue.
>
> I found so following error message is not too friendly (mainly because
> this functionality will be new)
>
> postgres=# select dense_rank(3,3,2) within group (order by num desc, odd)
> from test4;
> ERROR: Incorrect number of arguments for hypothetical set function
> LINE 1: select dense_rank(3,3,2) within group (order by num desc, od...
> ^
> postgres=# select dense_rank(3,3,2) within group (order by num desc) from
> test4;
> ERROR: Incorrect number of arguments for hypothetical set function
> LINE 1: select dense_rank(3,3,2) within group (order by num desc) fr...
> ^
> postgres=# select dense_rank(3,3) within group (order by num desc) from
> test4;
> ERROR: Incorrect number of arguments for hypothetical set function
> LINE 1: select dense_rank(3,3) within group (order by num desc) from...
> ^
> postgres=# select dense_rank(3,3) within group (order by num desc, num)
> from test4;
> dense_rank
> ------------
> 3
> (1 row)
>
> Probably some hint should be there?
>
> Regards
>
> Pavel
>
>
> 2013/10/2 Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>
>
>> On 09/30/2013 06:34 PM, Pavel Stehule wrote:
>> >
>> > I looked on this patch - it is one from long patches - so I propose to
>> > divide review to a few parts:
>> >
>> > a) a conformance with ANSI SQL
>> > b) check of new aggregates - semantic, implementation
>> > c) source code checking - usual patch review
>> >
>> > Now I would to work on @a
>>
>> I had an unexpected emergency come up, sorry about that. I plan on
>> doing B and C starting on Thursday (October 3).
>>
>> I am grateful to have Pavel's help, this is a big patch.
>>
>> --
>> Vik
>>
>>
>