Re: proposal: unescape_text function

čt 2. 7. 2020 v 17:27 odesílatel Daniel Gustafsson <daniel(at)yesql(dot)se> napsal:

> > On 23 Jun 2020, at 11:51, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
> > I changed the name to more accurately "unicode_unescape". Patch is
> assigned
>
> You've made this function return Oid, where it used to be void. Was that a
> copy-paste mistake? Else the code needs fixing as it doesn't return an Oid.
>
> +Oid
> +check_unicode_value(pg_wchar c)
> +{
> + if (!is_valid_unicode_codepoint(c))
> + ereport(ERROR,
> + (errcode(ERRCODE_SYNTAX_ERROR),
> + errmsg("invalid Unicode escape value")));
> +}
>
>
yes, it is my error

I am sending fixed patch

Thank you for check

Pavel

cheers ./daniel
>