Re: proposal: unescape_text function

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: unescape_text function
Date: 2020-07-02 15:27:52
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 23 Jun 2020, at 11:51, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:

> I changed the name to more accurately "unicode_unescape". Patch is assigned

You've made this function return Oid, where it used to be void. Was that a
copy-paste mistake? Else the code needs fixing as it doesn't return an Oid.

+check_unicode_value(pg_wchar c)
+ if (!is_valid_unicode_codepoint(c))
+ ereport(ERROR,
+ errmsg("invalid Unicode escape value")));

cheers ./daniel

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2020-07-02 15:38:02 Re: Built-in connection pooler
Previous Message James Coleman 2020-07-02 15:25:33 Re: suggest to rename enable_incrementalsort