| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-07-06 10:18:53 |
| Message-ID: | CAFiTN-vuhMhMwCdArfMx_t+HH-3d5=OBLMaD12m=Ft_Nr5id=A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 6, 2026 at 3:27 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Jul 6, 2026 at 1:14 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > On Fri, Jul 3, 2026 at 5:25 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> > >
> > > For the pushed patch (commit a5918fd), it seems we missed updating the
> > > pg_subscription catalog documentation for the two newly added columns:
> > >
> > > subconflictlogrelid | oid | | not null |
> > > subconflictlogdest | text | C | not null |
> > >
> > > Attached is a small patch for the same.
> >
> > Yeah that make sense, also added a extra change suggested by Peter for
> > <firstterm> markup.
> >
>
> Did you consider changing the code comments as suggested by me in
> email [1] to address Peter's complaint on repetitiveness of code
> comments?
>
> [1] - https://www.postgresql.org/message-id/CAA4eK1LH9N80WbFe88Lp0fFrXosVpYnh8iqtrh9kpfJR5N%3Dpyg%40mail.gmail.com
>
Not yet, I thought we hadn't reached a conclusion on this part.
--
Regards,
Dilip Kumar
Google
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-07-06 10:27:36 | Re: SECURITY LABEL ON PROPERTY GRAPH: supported? |
| Previous Message | Dean Rasheed | 2026-07-06 10:12:32 | Re: Global temporary tables |