| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-07-06 09:57:37 |
| Message-ID: | CAA4eK1LrUSYKOHX+TtQT8kF5QqGh0HTBDtgFAfYxhRc4Qj_Uuw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 6, 2026 at 1:14 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Fri, Jul 3, 2026 at 5:25 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > For the pushed patch (commit a5918fd), it seems we missed updating the
> > pg_subscription catalog documentation for the two newly added columns:
> >
> > subconflictlogrelid | oid | | not null |
> > subconflictlogdest | text | C | not null |
> >
> > Attached is a small patch for the same.
>
> Yeah that make sense, also added a extra change suggested by Peter for
> <firstterm> markup.
>
Did you consider changing the code comments as suggested by me in
email [1] to address Peter's complaint on repetitiveness of code
comments?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2026-07-06 10:12:32 | Re: Global temporary tables |
| Previous Message | Dean Rasheed | 2026-07-06 09:43:42 | Re: Global temporary tables |