From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
---|---|
To: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
Cc: | Maxim Boguk <maxim(dot)boguk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed. |
Date: | 2016-11-03 06:23:50 |
Message-ID: | CAFiTN-vcDoayjDfttY0PFMneWGFD2r3M=9SR_pG3rpTR8LWy3g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Thu, Nov 3, 2016 at 9:57 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> Thanks for your suggestion. Yes, I agree that adding a hint is good.
> Updated patch is attached with addition of hint message.
>
> 2016-11-03 14:56:28.685 AEDT [7822] ERROR: cannot copy to view "ttt_v"
> 2016-11-03 14:56:28.685 AEDT [7822] HINT: To enable copy to view, provide
> an INSTEAD OF INSERT trigger
> 2016-11-03 14:56:28.685 AEDT [7822] STATEMENT: COPY ttt_v FROM stdin;
Okay, Patch in general looks fine to me. One cosmetic comments, IMHO
in PG we follow operator at end of the line, so move '&&' to end of
the previous line.
+ if (cstate->rel->rd_rel->relkind != RELKIND_RELATION
+ && (!cstate->rel->trigdesc ||
+ !cstate->rel->trigdesc->trig_insert_instead_row))
Meanwhile I will test it and give the feedback.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Sandeep Thakkar | 2016-11-03 07:18:58 | Re: Compilation of timezone source with zic fails (on mountpoint) |
Previous Message | Haribabu Kommi | 2016-11-03 04:27:03 | Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed. |
From | Date | Subject | |
---|---|---|---|
Next Message | Kuntal Ghosh | 2016-11-03 06:24:05 | Re: WAL consistency check facility |
Previous Message | Thomas Munro | 2016-11-03 05:19:47 | Re: WIP: [[Parallel] Shared] Hash |