Re: Small issues with CREATE TABLE COMPRESSION

On Wed, May 5, 2021 at 11:02 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Wed, May 5, 2021 at 12:06 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >
>
> > > There are no tests in pg_dump to make sure that some ALTER
> > > MATERIALIZED VIEW or ALTER TABLE commands are generated when the
> > > compression of a matview's or table's column is changed.
> >
> > True, but it does seem to work. I am happy if you or anyone want to
> > write some tests.
>
> I think it will be really hard to generate such a test in pg_dump,
> because default we are compiling --without-lz4, which means we have
> only one compression option available, and if there is only one option
> available then the column compression method and the default
> compression method will be same so the dump will not generate an extra
> command of type ALTER TABLE... SET COMPRESSION.

I think we already have such test cases at least through pg_upgrade.
Basically, if you see in compression.sql we are not dropping the table
so that pg_upgrade and dump them and test. So if test run --with-lz4
then in pg_upgrade dump we can see ALTER TABLE... SET COMPRESSION type
of commands.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com