| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |
| Date: | 2022-08-03 15:55:10 |
| Message-ID: | CAFiTN-vU6ysOaR68KZLxbJ2cuimcJoTPR1L6p5D+eNtk8N4Z0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 3 Aug 2022 at 9:22 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Aug 3, 2022 at 7:15 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> > Another version of the patch which closes the smgr at the end using
> > smgrcloserellocator() and I have also added a commit message.
>
> Hmm, but didn't we decide against doing it that way intentionally? The
> comment you're deleting says "If we didn't do this and used the smgr
> layer directly, we would have to worry about invalidations."
I think we only need to worry if we keep the smgr reference around and try
to reuse it. But in this patch I am not keeping the reference to the smgr.
—
Dilip
> --
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2022-08-03 15:58:49 | Re: [PATCH] CF app: add "Returned: Needs more interest" |
| Previous Message | Robert Haas | 2022-08-03 15:51:57 | Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints |