| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: CHECKPOINT unlogged data |
| Date: | 2025-07-11 15:06:42 |
| Message-ID: | CAFiTN-ucuTP7ikR10ZH8Hm1or29LqzQph_MfpbfQk9YiGe9=DQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 11 Jul 2025 at 8:27 PM, Nathan Bossart <nathandbossart(at)gmail(dot)com>
wrote:
> On Fri, Jul 11, 2025 at 08:43:05AM +0530, Dilip Kumar wrote:
> > Thanks now, looks good to me.
>
> Thanks for reviewing.
>
> > Additionally IMHO it would be good to add tests with FLUSH_UNLOGGED TRUE
> > and FLUSH_UNLOGGED FALSE as well, I have added a simple 2 test for the
> > same in attached file.
>
> I'll add something like this before committing. In the future, please do
> not post small add-on patches like this because it confuses cfbot. If you
> must, I think appending an unknown extension like ".nocfbot" to the file
> name is sufficient to prevent cfbot from picking it up.
Yeah right, I somehow missed that part.. will take care in future. Thanks.
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrice Chapuis | 2025-07-11 15:12:02 | Re: failover logical replication slots |
| Previous Message | Nathan Bossart | 2025-07-11 14:57:02 | Re: CHECKPOINT unlogged data |