Re: Included xid in restoring reorder buffer changes from disk log message

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Included xid in restoring reorder buffer changes from disk log message
Date: 2021-04-30 06:23:43
Message-ID: CAFiTN-u336x+pD8NHuLQvz-k+VE3H8=_+XTLH_gMNX23i2y0Xw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 29, 2021 at 9:45 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Hi,
>
> While debugging one of the logical decoding issues, I found that xid was not included in restoring reorder buffer changes from disk log messages. Attached a patch for it. I felt including the XID will be helpful in debugging. Thoughts?
>

It makes sense to include xid in the debug message, earlier I thought
that will it be a good idea to also print the toplevel_xid. But I
think it is for debug purposes and only we have the xid we can fetch
the other parameters so maybe adding xid is good enough.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-04-30 07:06:07 Re: Enhanced error message to include hint messages for redundant options error
Previous Message vignesh C 2021-04-30 06:06:34 Re: Replication slot stats misgivings