Re: Decoding speculative insert with toast leaks memory

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Subject: Re: Decoding speculative insert with toast leaks memory
Date: 2021-06-14 06:35:51
Message-ID: CAFiTN-u=Thq2eN20ER670ci6RSwkGsm2kS2K_MY5uj1yZJ+4Ug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 14, 2021 at 9:44 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Mon, Jun 14, 2021 at 8:34 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > I think the test in this patch is quite similar to what Noah has
> > pointed in the nearby thread [1] to be failing at some intervals. Can
> > you also please once verify the same and if we can expect similar
> > failures here then we might want to consider dropping the test in this
> > patch for now? We can always come back to it once we find a good
> > solution to make it pass consistently.
>
> test insert-conflict-do-nothing ... ok 646 ms
> test insert-conflict-do-nothing-2 ... ok 1994 ms
> test insert-conflict-do-update ... ok 1786 ms
> test insert-conflict-do-update-2 ... ok 2689 ms
> test insert-conflict-do-update-3 ... ok 851 ms
> test insert-conflict-specconflict ... FAILED 3695 ms
> test delete-abort-savept ... ok 1238 ms
>
> Yeah, this is the same test that we have used base for our test so
> let's not push this test until it becomes stable.

Patches without test case.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v8-0001-96-Fix-decoding-of-speculative-aborts.patch text/x-patch 7.4 KB
v8-0001-v12-Fix-decoding-of-speculative-aborts.patch text/x-patch 7.1 KB
v8-0001-v10-Fix-decoding-of-speculative-aborts.patch text/x-patch 7.3 KB
v8-0001-Fix-decoding-of-speculative-aborts.patch text/x-patch 7.4 KB
v8-0001-v11-Fix-decoding-of-speculative-aborts.patch text/x-patch 7.1 KB
v8-0001-v13-Fix-decoding-of-speculative-aborts.patch text/x-patch 7.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-06-14 06:40:53 Re: [bug?] Missed parallel safety checks, and wrong parallel safety
Previous Message Amit Kapila 2021-06-14 06:32:12 Re: [bug?] Missed parallel safety checks, and wrong parallel safety