| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, akapila(at)postgresql(dot)org, nisha(dot)moond412(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: REASSIGN OWNED vs. relisshared dep on !relisshared |
| Date: | 2026-07-15 15:23:39 |
| Message-ID: | CAFiTN-tR9SdcEDbvHvGT0ArRLCVVLUgh9jYErHLhFU50V3Jbtw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 15, 2026 at 2:20 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Mon, 2026-07-13 at 17:04 +0530, Dilip Kumar wrote:
> > PFA a patch for skipping subscriptions belonging to different
> > databases.
>
> I suggest we add a few checks (or asserts) that subdbid==MyDatabaseId
> when reading pg_subscription from anywhere other than the launcher.
Yeah, I've done that
> Also, the REASSIGN OWNED path goes through
> AlterSubscriptionOwner_oid(), whereas both the REASSIGN OWNED and ALTER
> SUBSCRIPTION ... OWNER TO paths go through
> AlterSubscriptionOwner_internal(). It would be more clear to add the
> skipping logic in the former and an assert in the latter.
That makes sense; I've made the change.
> Other than that, LGTM.
Thanks for the review
--
Regards,
Dilip Kumar
Google
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Do-not-reassign-subscriptions-belonging-to-other-.patch | application/octet-stream | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Samokhvalov | 2026-07-15 15:26:36 | Re: Add wait events for server logging destination writes |
| Previous Message | Tom Lane | 2026-07-15 14:53:40 | Re: Fix GROUP BY ALL handling of ORDER BY operator semantics |