Re: Proposal: Conflict log history table for Logical Replication

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: Proposal: Conflict log history table for Logical Replication
Date: 2026-10-30 13:32:07
Message-ID: CAFiTN-siz5zJGtVH9qaMxuX7gcidO+-F8ej7CA3T1EjLvVUTwg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 30, 2026 at 5:49 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Oct 29, 2026 at 4:14 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
> > That makes sense; I will include this change in the next version, thanks.
> >
>
> Few comments:
> 1. CLT seems to have the same flaw as
> ad36e3608c8cb6f0848737ec81e548d4d3a0af3c. This is because it calls
> GetRelationIdentityOrPK() in insert_conflict_log_tuple() assuming it
> is the same index we used for search in FindReplTupleInLocalRel(). So,
> we need a similar fix here as well.
> 2. Apart from above, I have made a number of changes in the comments.
>
> Attached top-up patch atop 0001 and 0002. Kindly include this as well.

I have merged this patch along with the previous report by Shveta. I
also fixed the pgindent errors.

--
Regards,
Dilip Kumar
Google

Attachment Content-Type Size
v87-0003-Document-and-comment-that-replica-identity-rende.patch application/octet-stream 4.1 KB
v87-0001-Implement-the-conflict-insertion-infrastructure-.patch application/octet-stream 103.9 KB
v87-0002-Avoid-stalling-apply-on-the-conflict-log-table-w.patch application/octet-stream 29.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2026-10-30 13:51:19 Re: Incorrect CONTEXT reported for errors from parallel apply worker in logical replication
Previous Message Pavel Stehule 2026-10-30 13:26:56 Re: PL/pgSQL: apply the too_many_rows extra check to EXECUTE ... INTO