| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | Re: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-10-30 12:19:25 |
| Message-ID: | CAA4eK1LWUFCvyDPyB216ay_z5djS=cQMt7do1Xm=m9naSRx3UQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 29, 2026 at 4:14 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> That makes sense; I will include this change in the next version, thanks.
>
Few comments:
1. CLT seems to have the same flaw as
ad36e3608c8cb6f0848737ec81e548d4d3a0af3c. This is because it calls
GetRelationIdentityOrPK() in insert_conflict_log_tuple() assuming it
is the same index we used for search in FindReplTupleInLocalRel(). So,
we need a similar fix here as well.
2. Apart from above, I have made a number of changes in the comments.
Attached top-up patch atop 0001 and 0002. Kindly include this as well.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-v86_fix_RI_and_comments.1.patch | application/octet-stream | 10.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-10-30 12:37:41 | RE: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation |
| Previous Message | Ashutosh Bapat | 2026-10-30 12:01:18 | Faulty pg_get_shmem_pagesize() on Windows |