Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

On Tue, Mar 17, 2020 at 5:14 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Mar 16, 2020 at 3:24 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> >
>
> +
> + /*
> + * Indicate that the lock is released for certain types of locks
> + */
> +#ifdef USE_ASSERT_CHECKING
> + CheckAndSetLockHeld(locallock, false);
> +#endif
> }
>
> /*
> @@ -1618,6 +1666,11 @@ GrantLockLocal(LOCALLOCK *locallock, ResourceOwner owner)
> locallock->numLockOwners++;
> if (owner != NULL)
> ResourceOwnerRememberLock(owner, locallock);
> +
> + /* Indicate that the lock is acquired for certain types of locks. */
> +#ifdef USE_ASSERT_CHECKING
> + CheckAndSetLockHeld(locallock, true);
> +#endif
> }
>
> There is no need to sprinkle USE_ASSERT_CHECKING at so many places,
> having inside the new function is sufficient. I have changed that,
> added few more comments and
> made minor changes. See, what you think about attached?

Your changes look fine to me. I have also verified all the test and
everything works fine.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com