Re: Small issues with CREATE TABLE COMPRESSION

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <pchampion(at)vmware(dot)com>
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Date: 2021-05-06 16:03:53
Message-ID: CAFiTN-sb-hA9=85Hac9J7oY9B=4DE=fPinF=oKTL-QW7eQV1Hw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 6, 2021 at 5:42 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, May 06, 2021 at 10:45:53AM +0530, Dilip Kumar wrote:
> > Thanks, Robert and Michael for your input. I will try to understand
> > how it is done in the example shared by you and come up with the test
> > once I get time. I assume this is not something urgent.
>
> Thanks. FWIW, I'd rather see this gap closed asap, as features should
> come with proper tests IMO.

I have done this please find the attached patch.

>
> While on it, I can see that there is no support for --with-lz4 in the
> MSVC scripts. I think that this is something where we had better
> close the gap, and upstream provides binaries on Windows on their
> release page:
> https://github.com/lz4/lz4/releases
>
> And I am familiar with both areas, so I have no helping out and
> getting that in shape correctly before beta1.

I don't have much idea about the MSVC script, but I will try to see
some other parameters and fix this.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v1-0001-Add-pg_dump-test-case-for-TOAST-compression.patch text/x-patch 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-05-06 16:26:51 Re: Multiple hosts in connection string failed to failover in non-hot standby mode
Previous Message Joel Jacobson 2021-05-06 16:02:30 Re: COPY table_name (single_column) FROM 'unknown.txt' DELIMITER E'\n'